search

JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
123 stars 26 forks source link

Make `delaunayedges` return a proper iterator #59

Closed dkarrasch closed 2 years ago

dkarrasch commented 2 years ago

Fixes #47. I get a speed-up of factor 1000 in the benchmark given there (# 5.199 μs (0 allocations: 0 bytes) vs. # 8.502 ms (586 allocations: 27.95 KiB)). This heavily relies on @CarpeNecopinum's work in https://github.com/JuliaGeometry/VoronoiDelaunay.jl/issues/47#issuecomment-513245442.

Co-authored-by: Christian Mattes CarpeNecopinum@users.noreply.github.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #59 (d4490b1) into master (0779096) will increase coverage by 0.15%. The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   87.03%   87.19%   +0.15%     
==========================================
  Files           1        1              
  Lines         432      445      +13     
==========================================
+ Hits          376      388      +12     
- Misses         56       57       +1
Impacted Files Coverage Δ
src/VoronoiDelaunay.jl 87.19% <97.77%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0779096...d4490b1. Read the comment docs.

dkarrasch commented 2 years ago

Hm, I'm not sure the test of the length of the iterator are fully appropriate, as we seem to have issues with missing triangles etc. But at least this gives the same result as before and is much much faster.