JuliaGeometry / VoronoiDelaunay.jl

Fast and robust Voronoi & Delaunay tessellation creation with Julia
Other
123 stars 26 forks source link

Add RNG to push function #65

Closed skygering closed 1 year ago

skygering commented 1 year ago

Hi! I was working with the VoronoiCells package and getting small differences when creating the tessellations with the same generator points, as can be seen in this issue.

Adding in a random number generator seems to fix that issue and I am now getting consistent answers.

It would be amazing if this pull request could be approved so that I can make a pull request with my fix to VoronoiCells as well. I am happy to change anything needed. Thank you!

codecov[bot] commented 1 year ago

Codecov Report

Merging #65 (ebf4c26) into master (02a2eb7) will decrease coverage by 0.70%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   87.21%   86.52%   -0.70%     
==========================================
  Files           1        1              
  Lines         446      460      +14     
==========================================
+ Hits          389      398       +9     
- Misses         57       62       +5     
Impacted Files Coverage Δ
src/VoronoiDelaunay.jl 86.52% <100.00%> (-0.70%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sjkelly commented 1 year ago

Thanks!