search

JuliaGizmos / Blink.jl

Web-based GUIs for Julia
Other
360 stars 75 forks source link

Rename the setters in the `Window` API functions with a `!` #161

Open NHDaly opened 6 years ago

NHDaly commented 6 years ago

We should rename the Window API functions to be more julian. Either adding a ! at the end of setters, or more explicitly set__ and get__ or is__?

That is, for these ones: https://github.com/JunoLab/Blink.jl/blob/d984c4d99586c451395cba55eadf8b47d9cac091/src/AtomShell/window.jl#L87-L136

There's a setter and a getter for a bunch of them (position, size, etc).

Can I rename those to position!(w, x, y) and position(w)?

(I came across this as part of https://github.com/JunoLab/Blink.jl/issues/160 😄)

NHDaly commented 5 years ago

Cross Referencing related discussion here: https://github.com/JuliaGizmos/Blink.jl/pull/212#issuecomment-518504444

NHDaly commented 5 years ago

Another API renaming x-ref: https://github.com/JuliaGizmos/Blink.jl/issues/122#issuecomment-516578101

load! should be renamed import!.