search

JuliaGizmos / Blink.jl

Web-based GUIs for Julia
Other
355 stars 74 forks source link

Bugfixes and API changes for updated Electron #309

Open mosullivan93 opened 1 year ago

mosullivan93 commented 1 year ago

The API for performing dialog operations has changed significantly since the last version of Electron used in the package. Specifically, this PR makes the necessary backend changes to remedy issues with the dialog widgets seen with the updated Electron from Blink >=v0.12.6. This PR may require additional thought about an update to Project.toml to ensure that the mutual dependencies on the patches will be satisfied by users of both packages.

This patch provides the following improvements: 1) A more robust override mechanism for BrowserWindow defaults. 2) Compatibility with or without contextIsolation for asynchronous dialog operations. 3) A user friendly mechanism for adding renderer preload scripts to extend the namespace of isolated windows. 4) Miscellaneous bugfixes: Julia icon path, keys in window_defaults dictionary, syntax update for invoking debugger.

Blink.jl InteractBase.jl Status
Blink v0.12.5 (Electron 4.04) InteractBase v0.10.5 Working
Blink v0.12.5 (Electron 4.04) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.5 (Electron 4.04) InteractBase #177 Working
Blink v0.12.5 (Electron 4.04) InteractBase #178 Broken (no dialog)
Blink.jl InteractBase.jl Status
Blink v0.12.6 (Electron 19.09) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.7 (Electron 19.09) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.7 (Electron 19.09) InteractBase #177 Broken (no dialog)
Blink #309 (Electron 19.09) InteractBase #177 Broken (no dialog)
Blink #309 (Electron 19.09) InteractBase #178 Working
mosullivan93 commented 1 year ago

Converting to draft. I would like to do a few more tests on the new features and add documentation for them.