tkoolen commented 6 years ago

Also fixes #5.

tkoolen commented 6 years ago

Alright, tests are passing on 0.6 again, and tests also pass on 1.0 (without depwarns) with:

codecov-io commented 6 years ago

Codecov Report

Merging #6 into master will increase coverage by 92.13%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage    2.59%   94.73%   +92.13%     
===========================================
  Files           4        3        -1     
  Lines          77       19       -58     
===========================================
+ Hits            2       18       +16     
+ Misses         75        1       -74

Impacted Files	Coverage Δ
src/layout.jl	`100% <ø> (+96.15%)`	:arrow_up:
src/CSSUtil.jl	`83.33% <ø> (+74.24%)`	:arrow_up:
src/theme.jl	`100% <100%> (+100%)`	:arrow_up:
src/markdown.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b73d647...3ae9b11. Read the comment docs.

tkoolen commented 6 years ago

All done. Should I disallow failures on 1.0 on Travis?

piever commented 6 years ago

Yes, if it's already passing on 1.0 we don't need to allow failures. Other than that, LGTM.

Btw, you JuliaRobotics guys really are heroes, you and Robin have fixed so many things lately in the web stack!

piever commented 6 years ago

And one last thing: the README also needs to be updated to node

tkoolen commented 6 years ago

Thanks!

Addressed comments.

Just for clarity: to get CI to pass on 1.0 we still need the WebIO tag, but after that tag CSSUtil is good on 1.0.

JuliaGizmos / CSSUtil.jl

Fixes for 0.7 and add some basic tests #6

Codecov Report