Closed rohitvarkey closed 7 years ago
datepicker
is a good idea. I believe it will make Escher more attractive to users, the more ready-to-use elements it has the betterthe Signal value in the Slider example is frozen, the same in the codemirror
They work fine for me.
the initial value of the Signal can be set to be different from the widget. as a result the first render may not be accurate, like the slider second example and the radio button. Can you use the value of the signal to set the initial widget value?
I've set the initial value of the Signal and the widget to be same, so it should be correct in the first render itself!
+1
is the goal to explain foldp
in a different guide? also forms, samplers (e.g. code mirror with ctrl+enter) and collectors (minesweeper-like things)
I was using http://escher-jl.org/widgets-api.html as a reference. I think this can focus on just introducing widgets with their default behaviours.
Having a separate guide for explaining Reactive features (foldp
etc) and then one more on forms, samplers and collectors will be better than putting everything in one guide I feel.
There is also the opinionated http://escher-jl.org/reactive-guide.html
you are right, I was messing with it and got those issues. on reload, they worked as expected.
I've been trying to get the date picker to work, but when included in an Escher session, the layout is all messed up. Funnily enough, it becomes correct when the browser is resized!
I'm wondering if we should remove the datepicker code for now and merge this PR.
I believe we should avoid confusion. the users might think something is wrong with their code. on the other hand if you issue a usage warning, it might be accetable :)
Is there anything keeping this from being merged? There are two discussions going on here, improving the docs and tangent code issues
I think @rohitvarkey never got around to dealing with the ugly calendar issue. I say we merge this for now.
Sorry everyone. Lost track of the PR for a bit there. I couldn't get the calendar to work nicely and from what I remember, didn't find any good replacements either. So the datepicker
code is essentially dead code as @shashi mentioned. We should probably remove it.
Yes we should remove it.
This guide covers
The
datepicker
asset isn`t correct, so I've commented that out for the time being. Should I install this as a replacement?@shashi @alinchis Please review and give me your suggestions!