search

JuliaGizmos / Escher.jl

Composable Web UIs in Julia
https://juliagizmos.github.io/Escher.jl
Other
335 stars 63 forks source link

Replace `_print` with `lower` #173

Closed TotalVerb closed 7 years ago

TotalVerb commented 7 years ago

In JSON v0.7.0 and beyond, overloads of _print are deprecated in favour of overloading the simpler lower function.

The new JSON tag is not yet merged; see https://github.com/JuliaLang/METADATA.jl/pull/5988. I'll ping you when it is.

TotalVerb commented 7 years ago

Should be good to merge now.

TotalVerb commented 7 years ago

Oops, I didn't mean to close.

randyzwitch commented 7 years ago

This is failing on the overnight/v0.6, but passes for 0.5. Do we merge this, then fix the 0.6 issues down the line? Or, @TotalVerb can you figure out what will make this pass for 0.6?

TotalVerb commented 7 years ago

@randyzwitch Thanks for bringing that to my attention. I'll test on v0.6 and figure out what's causing the issues.

TotalVerb commented 7 years ago

@randyzwitch I think the problem is independent of this PR. I believe I've found the issue and will submit an unrelated PR addressing it.

TotalVerb commented 7 years ago

@randyzwitch Although I suspected that I found the issue, I don't think I am able to address it. Perhaps it is also a local issue on my configuration only. See #176.