JuliaGizmos / Escher.jl

Composable Web UIs in Julia
https://juliagizmos.github.io/Escher.jl
Other
335 stars 63 forks source link

Fix selection behavior for polymer 1.0 #75

Closed mdcfrancis closed 8 years ago

mdcfrancis commented 8 years ago

Polymer 1.0 defines pages as div elements in current examples. Virtual patch of attribute boolean values fails with sneaky dom and results in an always true value. This breaks the tabbed pages example.

mdcfrancis commented 8 years ago

I believe you can use the reflect to attribute on the polymer element to lift the value. But your solution looks good.

shashi commented 8 years ago

having properties and attributes mean different things pretty messy. We will find a nice way to fix #72. But for now, could you update the PR?

mdcfrancis commented 8 years ago

Sure will. Thanks for looking.