search

JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

make code work on both old and new knockout #125

Closed piever closed 5 years ago

piever commented 5 years ago

No longer rely on numericValue but explicitly create numeric observable on the javascript side.

codecov-io commented 5 years ago

Codecov Report

Merging #125 into master will increase coverage by 0.28%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   78.36%   78.64%   +0.28%     
==========================================
  Files          10       10              
  Lines         476      487      +11     
==========================================
+ Hits          373      383      +10     
- Misses        103      104       +1
Impacted Files Coverage Δ
src/utils.jl 52.94% <ø> (ø) :arrow_up:
src/InteractBase.jl 100% <ø> (ø) :arrow_up:
src/optioninput.jl 86.95% <100%> (+0.14%) :arrow_up:
src/output.jl 87.36% <50%> (+0.13%) :arrow_up:
src/input.jl 82.25% <90.9%> (+0.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aeda4e8...0d4873d. Read the comment docs.