search

JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

Fix slider #143

Closed piever closed 5 years ago

piever commented 5 years ago

Fixes issue #142: now the methods that actually calls javascript needs to be AbstractUnitRange and I subtract the first value before calling getindex on the javascript side.

codecov-io commented 5 years ago

Codecov Report

Merging #143 into master will decrease coverage by 0.33%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage    75.9%   75.57%   -0.34%     
==========================================
  Files          10       10              
  Lines         523      524       +1     
==========================================
- Hits          397      396       -1     
- Misses        126      128       +2
Impacted Files Coverage Δ
src/slider.jl 72.22% <100%> (-1.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bcc557...4bcd597. Read the comment docs.

hhaensel commented 5 years ago

The slider works fine now! Good job!