JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

Updates for Observables 0.3 and misc updates to compat bounds #154

Closed fredrikekre closed 4 years ago

fredrikekre commented 4 years ago

There is one depwarn during tests (here with --depwarn=error):

(InteractBase) pkg> test
   Testing InteractBase
 Resolving package versions...
input: Error During Test at /home/fredrik/dev/InteractBase/test/test_observables.jl:1
  Got exception outside of a @test
  Accessing `scope.id` is deprecated, use `scopeid(scope)` instead.
  Stacktrace:
   [1] depwarn(::String, ::Symbol) at ./deprecated.jl:77
   [2] getproperty(::Scope, ::Symbol) at /home/fredrik/.julia/packages/WebIO/2mZPb/src/scope.jl:63
   [3] jsexpr(::Observable{Int64}) at /home/fredrik/.julia/packages/JSExpr/SzJLT/src/JSExpr.jl:66
   [4] #knockout#1(::Array{Any,1}, ::Array{Any,1}, ::typeof(Knockout.knockout), ::Node{WebIO.DOM}, ::Array{Pair{String,Any},1}, ::WebIO.JSString) at /home/fredrik/.julia/packages/Knockout/1sDlc/src/Knockout.jl:5
0
   [5] #knockout at ./none:0 [inlined]
   [6] #input#47(::WebIO.JSString, ::Array{Any,1}, ::Nothing, ::String, ::String, ::String, ::Dict{Any,Any}, ::Bool, ::Array{Any,1}, ::Dict{Any,Any}, ::String, ::String, ::String, ::Int64, ::Base.Iterators.Pairs
{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(input), ::NativeHTML, ::String) at /home/fredrik/dev/InteractBase/src/input.jl:259
   [7] (::Widgets.var"#kw##input")(::NamedTuple{(:typ,),Tuple{String}}, ::typeof(input), ::NativeHTML, ::String) at ./none:0
   [8] #input#40(::Base.Iterators.Pairs{Symbol,String,Tuple{Symbol},NamedTuple{(:typ,),Tuple{String}}}, ::typeof(input), ::String) at /home/fredrik/.julia/packages/Widgets/451tD/src/defaults.jl:10
   [9] (::Widgets.var"#kw##input")(::NamedTuple{(:typ,),Tuple{String}}, ::typeof(input), ::String) at ./none:0
   [10] #input#54(::String, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(input), ::NativeHTML) at /home/fredrik/dev/InteractBase/src/input.jl:273
   [11] input(::NativeHTML) at /home/fredrik/dev/InteractBase/src/input.jl:266
   [12] #input#40(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::typeof(input)) at /home/fredrik/.julia/packages/Widgets/451tD/src/defaults.jl:10
   [13] input() at /home/fredrik/.julia/packages/Widgets/451tD/src/defaults.jl:8
   [14] top-level scope at /home/fredrik/dev/InteractBase/test/test_observables.jl:2
   [15] top-level scope at /home/fredrik/julia13/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [16] top-level scope at /home/fredrik/dev/InteractBase/test/test_observables.jl:2
   [17] include at ./boot.jl:328 [inlined]
   [18] include_relative(::Module, ::String) at ./loading.jl:1105
   [19] include(::Module, ::String) at ./Base.jl:31
   [20] include(::String) at ./client.jl:424
   [21] top-level scope at /home/fredrik/dev/InteractBase/test/runtests.jl:10
   [22] include at ./boot.jl:328 [inlined]
   [23] include_relative(::Module, ::String) at ./loading.jl:1105
   [24] include(::Module, ::String) at ./Base.jl:31
   [25] include(::String) at ./client.jl:424
   [26] top-level scope at none:6
   [27] eval(::Module, ::Any) at ./boot.jl:330
   [28] exec_options(::Base.JLOptions) at ./client.jl:263
   [29] _start() at ./client.jl:460

which seems to be in Knockout.jl? I did not have time to track that down, but it is of no fault of this package at least.

piever commented 4 years ago

Sure, I wouldn't worry about that warning. Thanks for the PR!