search

JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

improve type stability, matching changes in Widgets.jl #167

Closed rafaqz closed 2 years ago

rafaqz commented 2 years ago

Companion PR to https://github.com/piever/Widgets.jl/pull/48

Mostly just type stability improvments - ending up with a 5x improvement in time to first slider.

(Tests wont pass without the Widgets.jl PR)

piever commented 2 years ago

Thanks for this companion PR! I was thinking, maybe it'd be best to check out Widgets master (can be done here in the CI file), so that we are sure that the combination works well, before tagging the release of Widgets.

rafaqz commented 2 years ago

This will need a few changes now, I'll try testing as you suggest.

Also check the WebIO.jl prs, they help a bit too.

rafaqz commented 2 years ago

This should do it. I had to change one of the tests that uses sleep, because its faster now ;)

rafaqz commented 2 years ago

This should be ready to merge.

Along with the PRs to JSON.jl, Parsers.jl, Widgets.jl and AssetRegistry.jl the first slider is taking 1 second on my laptop :)

piever commented 2 years ago

Thanks again for the very nice series of PR! I've tested locally and it does feel much snappier (even without having checked out all the other PRs in the ecosystem).

Looks good to me, I'll wait a little bit to see if other people comment and then merge and tag both InteractBase and Widgets.