search

JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

Fix theme undefined in dialog #177

Closed mkitti closed 1 year ago

mkitti commented 1 year ago

Fix #176

mkitti commented 1 year ago

Thanks for looking this over.

beorostica commented 1 year ago

We are really interested in using this feature soon for KomaMRI.jl. When would this be merged in a new version of IntectBase and updated in the julia registries?

mkitti commented 1 year ago

We'll need @piever to move forward. Actually, I'm not sure who has merge capabilities here.

piever commented 1 year ago

So, I'm happy to tag a release, but I agree that it is not ideal that I'm the only person with merging privileges here. Should I simply move this repo to JuliaGizmos? It seems like the more robust solution going forward.

cc: @travigd, @shashi, @rafaqz

mkitti commented 1 year ago

Should I simply move this repo to JuliaGizmos?

I think this makes sense especially if this is not being very actively developed at the moment.

shashi commented 1 year ago

@piever Sounds fine to me as long as you will still retain merge privileges :)

piever commented 1 year ago

Perfect, I've just moved the repo to JuliaGizmos. Does this PR warrant a release or should we wait for #178 to be ready?

mkitti commented 1 year ago

I believe it does warrant a release. Users are reporting issues with Interact.jl: https://github.com/JuliaGizmos/Interact.jl/issues/414