search

JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

Update dialog JavaScript for newer Electron API #178

Open mosullivan93 opened 1 year ago

mosullivan93 commented 1 year ago

This PR fixes the open/save dialog functionality for the latest version of the Blink package. Even after fixing the undefined variables, differences in the security model of newer versions of Electron meant that a few tweaks were necessary to ensure compatibility.

This patch is co-dependent on an update to Blink.jl, as well. Merging PR JuliaGizmos/Blink.jl#309 and updating the compatibility constraints for Project.toml may be necessary to prevent the potential for users to end up with a broken project.

This patch supplements the resolution to JuliaGizmos/Interact.jl#414 (in piever/InteractBase.jl#176) to fix an additional complication arising from the updated Electron in Blink.jl.

Blink.jl InteractBase.jl Status
Blink v0.12.5 (Electron 4.04) InteractBase v0.10.5 Working
Blink v0.12.5 (Electron 4.04) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.5 (Electron 4.04) InteractBase #177 Working
Blink v0.12.5 (Electron 4.04) InteractBase #178 Broken (no dialog)
Blink.jl InteractBase.jl Status
Blink v0.12.6 (Electron 19.09) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.7 (Electron 19.09) InteractBase v0.10.9 Broken (theme undefined)
Blink v0.12.7 (Electron 19.09) InteractBase #177 Broken (no dialog)
Blink #309 (Electron 19.09) InteractBase #177 Broken (no dialog)
Blink #309 (Electron 19.09) InteractBase #178 Working
mosullivan93 commented 1 year ago

Converting to draft. This PR depends on the changes in Blink#309.

beorostica commented 1 year ago

This would be very useful for solving a bug in our user interface in the Koma.jl package. Is there any news on this @mosullivan93?