JuliaGizmos / InteractBase.jl

Build interactive HTML5 widgets in Julia
Other
27 stars 23 forks source link

avoid using all of Blink and Juno to prevent warnings #58

Closed rdeits closed 6 years ago

rdeits commented 6 years ago

The call to using Blink inside the @require block causes a warning to printed (since Blink exports its own @js macro that conflicts with JSExpr), and likewise for Juno.input. These warnings don't break anything, but they're a little annoying. Removing the usings fixes the problem.

Before:

julia> using InteractBase

julia> using Blink
INFO: Loading HttpServer methods...
WARNING: using Blink.@js in module InteractBase conflicts with an existing identifier.

julia> using Juno
WARNING: using Juno.input in module InteractBase conflicts with an existing identifier.

After:

julia> using InteractBase

julia> using Blink
INFO: Loading HttpServer methods...

julia> using Juno
codecov-io commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files          13       13           
  Lines         310      310           
=======================================
  Hits          229      229           
  Misses         81       81
Impacted Files Coverage Δ
src/providers/blink.jl 0% <ø> (ø) :arrow_up:
src/providers/atom.jl 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f92f97...3781c5d. Read the comment docs.

piever commented 6 years ago

Nice fix, thanks!