search

JuliaGizmos / WebIO.jl

A bridge between Julia and the Web.
https://juliagizmos.github.io/WebIO.jl/latest/
Other
228 stars 64 forks source link

setexcludinghandlers! was removed in Observables 0.5 #493

Closed rasmushenningsson closed 2 years ago

rasmushenningsson commented 2 years ago

With the compat update to support Observables 0.5, we get problems here https://github.com/JuliaGizmos/WebIO.jl/blob/c818b1f57758a32bbafebea4fe16ed41192bd9ff/src/scope.jl#L352 since setexcludinghandlers! no longer exists. I'm not sure what a proper fix is.

The easiest fix would probably be to just access the field directly, since the function was implemented like this in Observables.jl: setexcludinghandlers!(obs::AbstractObservable, val) = observe(obs).val = val

PetrKryslUCSD commented 2 years ago

Is there some fix? PlotlyJS is practically unusable because of this error.

mzaffalon commented 2 years ago

@PetrKryslUCSD I pin WebIO to v0.8.17 as a temporarily workaround: using Pkg; Pkg.add("WebIO"); Pkg.pin(name="WebIO", version="0.8.17").

PetrKryslUCSD commented 2 years ago

Excellent, that worked! Thanks!

rasmushenningsson commented 2 years ago

bump :slightly_smiling_face:

twavv commented 2 years ago

Open to PRs here. Looks like this was a breaking change introduced to Observables.jl in https://github.com/JuliaGizmos/Observables.jl/pull/84/files#diff-717dd66a485f4523942145feb17dfcebc7bf9e137ee03fa29c1ef8c8c3b1cad6L272 (cc @SimonDanisch)

rasmushenningsson commented 2 years ago

I opened a PR in Observables (https://github.com/JuliaGizmos/Observables.jl/pull/97) to reintroduce the function instead. If they don't want to reintroduce it, I'll open a PR with a local fix here.

rcqls commented 2 years ago

I opened a PR in Observables (JuliaGizmos/Observables.jl#97) to reintroduce the function instead. If they don't want to reintroduce it, I'll open a PR with a local fix here.

@rasmushenningsson Why you don't do that. If you have a fix it could be a good point. I can't understand why PlotlyJS event handling is stuck because of this issue. That"s weird in the excellent Julia ecosystem.

rasmushenningsson commented 2 years ago

The PR in Observables was just merged, so no need for any action here.