search

JuliaGraphics / Cairo.jl

Bindings to the Cairo graphics library.
Other
86 stars 56 forks source link

Fix stream handling #325

Closed yuyichao closed 4 years ago

yuyichao commented 4 years ago

Passing immutable object as Any to C code does not guarantee pointer identity with the original object/object stored in parent object.

Fix #323

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 92.584% when pulling d53c5cece6b5ff473550509a86c30d8df2f2281b on yyc/stream into a591b52ccc809d3179c6cd1dca2eadb947e5986e on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #325 into master will increase coverage by 0.25%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   90.67%   90.92%   +0.25%     
==========================================
  Files           1        1              
  Lines         461      474      +13     
==========================================
+ Hits          418      431      +13     
  Misses         43       43
Impacted Files Coverage Δ
src/Cairo.jl 90.92% <100.00%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a591b52...d53c5ce. Read the comment docs.

lobingera commented 4 years ago

Thank you.

I still might have some questions understanding the solution.