JuliaGraphics / ColorSchemes.jl

colorschemes, colormaps, gradients, and palettes
http://juliagraphics.github.io/ColorSchemes.jl/
Other
187 stars 33 forks source link

Take Paul Tol's color schemes seriously #102

Closed tecosaur closed 1 year ago

tecosaur commented 1 year ago
  1. The following missing Tol colour schemes are added:

    • high-contrast (as tol_highcontrast, qualitative)
    • medium-contrast (as tol_medcontrast, qualitative)
    • vibrant (as tol_vibrant, qualitative)
    • nightfall (as tol_nightfall, continuous)
    • incandescent (as tol_incandescent, continuous)
  2. The ordering of the qualitative color schemes is updated to match the ordering recommended on Paul Tol's website in this section:

image

  1. The incorrect second colour in the iridescent colour scheme is corrected (#FCF705 -> #FCF7D5).

  2. Remove #DDDDDD as the final entry of tol_muted. It is not part of the colour scheme but the "bad data" colour for the scheme. No other colour scheme with a "bad data" colour has it as part of the scheme.

  3. A consistent naming scheme (tol_SCHEME) is also enforced, instead of having every second tol colour scheme follow different pattern.

Tol produces two variants on Colorbrewer schemes, which are both named inconsistently with Colorbrewer in different ways.

Tol's AVHRR global land cover classification scheme is incorrectly called "groundcover" and skips the "tol" prefix.

Similarly, Tol's iridescent scheme is missing the "tol_" prefix.

All four of these changes have duplicate entries created under the original name to preserve compatibility.

  1. The colour scheme tol_ylorbr is registered separately but identically to tol_YlOrBr.
codecov[bot] commented 1 year ago

Codecov Report

Base: 74.35% // Head: 74.35% // No change to project coverage :thumbsup:

Coverage data is based on head (085c6cd) compared to base (24a5153). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ======================================= Coverage 74.35% 74.35% ======================================= Files 1 1 Lines 117 117 ======================================= Hits 87 87 Misses 30 30 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

cormullion commented 1 year ago

Thanks!