JuliaGraphics / ColorSchemes.jl

colorschemes, colormaps, gradients, and palettes

http://juliagraphics.github.io/ColorSchemes.jl/

Other

187 stars 34 forks source link

Create cividis.jl #64

Closed briochemc closed 3 years ago

briochemc commented 3 years ago

Not sure how to add colormaps like this, but I thought this one was missing, so I tried to add it 😄

I guess it must be added to the docs too but I'm not sure where. And probably needs some tests too :)

Some pointers/tips would be much helpful! 😃

cormullion commented 3 years ago

Hi! Good idea... Will this not clash with the one in Plots.jl (http://docs.juliaplots.org/latest/generated/colorschemes/#Pre-defined-ColorSchemes)?

Schemes are automatically documented during the build process, as long as they belong to one of the categories (https://github.com/JuliaGraphics/ColorSchemes.jl/blob/master/docs/src/basics.md#pre-defined-schemes). (So you would need a new category?) I'm hoping to redo these in SVG, once the next release of Documenter.jl is out.

briochemc commented 3 years ago

Hi! Good idea... Will this not clash with the one in Plots.jl (http://docs.juliaplots.org/latest/generated/colorschemes/#Pre-defined-ColorSchemes)?

Oh good catch! I knew I saw/used it before... I was just surprised I could not find it directly in ColorSchemes... Sorry for the noise then?

cormullion commented 3 years ago

Good practice though?! 😄

briochemc commented 3 years ago

Could you ELI5 why these "predefined" colors in Plots were not moved to ColorSchemes? 🙏

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (9d4c3b2) into master (ece0ffe) will increase coverage by 0.43%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   57.89%   58.33%   +0.43%     
==========================================
  Files           1        1              
  Lines          95       96       +1     
==========================================
+ Hits           55       56       +1     
  Misses         40       40

Impacted Files	Coverage Δ
src/ColorSchemes.jl	`58.33% <100.00%> (+0.43%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ece0ffe...9d4c3b2. Read the comment docs.

cormullion commented 3 years ago

No 😄

cormullion commented 3 years ago

But the surgeons who performed the operation of integrating ColorSchemes.jl into Plots.jl may know.