JuliaGraphics / ColorSchemes.jl

colorschemes, colormaps, gradients, and palettes
http://juliagraphics.github.io/ColorSchemes.jl/
Other
187 stars 33 forks source link

:zap: New colorschemes based on Julia colors. #85

Closed davibarreira closed 2 years ago

davibarreira commented 2 years ago

@cormullion we meet again! :grin:

I didn't see any color schemes based on Julia's colors. So here is a PR with a proposal of color schemes based on Juila. If you find the color schemes redundant, feel free to reject the PR.

davibarreira commented 2 years ago

Hi Davi. This looks cool, thanks!

You'll need to remove the stray semicolons.

What's the thinking behind the :jyellow and :jgray?

The yellow and gray are just extra colors to the regular Julia color scheme that I felt complemented the original palette. I mean, having only 4 colors might be too little for some plots, and I felt that the yellow and the gray matched the original Julia colors.

But I'll remove them. I think it's better to stick only to the originals.

davibarreira commented 2 years ago

About the color gradations (jblue, jred, etc). They are a variation in 10% of the colors.

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (9140b19) into master (f21c771) will increase coverage by 0.22%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   75.22%   75.45%   +0.22%     
==========================================
  Files           1        1              
  Lines         109      110       +1     
==========================================
+ Hits           82       83       +1     
  Misses         27       27              
Impacted Files Coverage Δ
src/ColorSchemes.jl 75.45% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f21c771...9140b19. Read the comment docs.

davibarreira commented 2 years ago

Forgot to add the legacy colors. These are the colors from the original logo :)

cormullion commented 2 years ago

That's great! Thanks so much! :)

Loose ends: