search

JuliaGraphics / ColorSchemes.jl

colorschemes, colormaps, gradients, and palettes
http://juliagraphics.github.io/ColorSchemes.jl/
Other
187 stars 33 forks source link

Optimized get and extra docs #92

Closed cormullion closed 2 years ago

cormullion commented 2 years ago

includes code from https://github.com/JuliaGraphics/ColorSchemes.jl/issues/91

extra section in docs for https://github.com/JuliaGraphics/ColorSchemes.jl/issues/90

codecov[bot] commented 2 years ago

Codecov Report

Merging #92 (2229f54) into master (3b9cafc) will decrease coverage by 1.31%. The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   76.31%   75.00%   -1.32%     
==========================================
  Files           1        1              
  Lines         114      116       +2     
==========================================
  Hits           87       87              
- Misses         27       29       +2
Impacted Files Coverage Δ
src/ColorSchemes.jl 75.00% <91.66%> (-1.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b9cafc...2229f54. Read the comment docs.

cormullion commented 2 years ago

@stevengj Following your suggestions...

Documentation preview at

https://juliagraphics.github.io/ColorSchemes.jl/previews/PR92/goodpractice/

I added a section which looks like this:

Screenshot 2022-04-22 at 11 00 27

which contains some comments about Lightness and perceptual uniformity.