Open kimikage opened 4 years ago
What's this again? https://github.com/JuliaGraphics/ColorTypes.jl/blob/53c59257c3dddbebb05a899324a202a89d5ed213/src/traits.jl#L176
Is this necessary? If so, why is it only for instances?
Personally, it looks better to remove this than to add support for Number
to color_type
andbase_colorant_type
.
If we relax the component types to Real
in v0.13 (cf. https://github.com/JuliaGraphics/ColorTypes.jl/issues/131#issuecomment-824544538), this issue will be solved automatically. Of course, there are several problems with the relaxing, though.
I don't know whether
GrayA{Bool}
andAGray{Bool}
are really needed. I don't mind if they are invalid types, but there are some inconsistencies.I don't fully understand why
Bool
is allowed only forGray
and not forRGB
. I also thinkGray{Bool}
is useful for binary (black/white) images (cf. PR #35, issue #76, #29), but that is not a reason to prohibitGrayA{Bool}
andAGray{Bool}
.