search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
77 stars 35 forks source link

Add a few more precompiles #214

Closed timholy closed 3 years ago

timholy commented 3 years ago

These precompiles help ImageCore precompile other MethodInstances.

codecov[bot] commented 3 years ago

Codecov Report

Merging #214 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   94.09%   94.13%   +0.04%     
==========================================
  Files           8        8              
  Lines         694      699       +5     
==========================================
+ Hits          653      658       +5     
  Misses         41       41
Impacted Files Coverage Δ
src/precompile.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fd7383...edfa4ba. Read the comment docs.

timholy commented 3 years ago

Benefits are not huge but it helps other packages. There's a chain from ColorTypes->ImageCore->PNGFiles, and load(filename) takes 0.2s to infer which is a substantial time.