search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
77 stars 35 forks source link

Flaky test #225

Closed timholy closed 3 years ago

timholy commented 3 years ago

rand: Error During Test at D:\a\ColorTypes.jl\ColorTypes.jl\test\operations.jl:61 Unexpected Pass Expression: all(all_in_range, rand(ARGB{Q3f12}, 1)) Got correct result, please change to @test if no longer broken.

From https://github.com/JuliaGraphics/ColorTypes.jl/pull/224/checks?check_run_id=1869979411

kimikage commented 3 years ago

I'm sorry. I had initially intended to generate 10×10 random colors (https://github.com/JuliaGraphics/ColorTypes.jl/commit/cf513d11551328471f4ae99c3f55eb51742566e4). I must have rewritten it during the experiment and forgot to put it back.

all(all_in_range, rand(ARGB{Q3f12}, 10, 10))

2^-400 is a sufficiently small probability that it is less than the probability of my typo. :joy: If you are unsure, let's make it 1000. :smile:

timholy commented 3 years ago

No worries, and a failure rate that is smaller than the number of, say, PRs in Julia's history is not something I'd worry about :smile:.