search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
78 stars 36 forks source link

Remove assertions in "src/precompile.jl" #234

Closed kimikage closed 3 years ago

kimikage commented 3 years ago

The bit rot in this package itself should be detected by testing with Julia v1.7.0-DEV.694 or later.

This is an alternative to PR #232.

codecov[bot] commented 3 years ago

Codecov Report

Merging #234 (ac51f26) into master (2d72c21) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files           8        8           
  Lines         745      745           
=======================================
  Hits          710      710           
  Misses         35       35
Impacted Files Coverage Δ
src/precompile.jl 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d72c21...ac51f26. Read the comment docs.

kimikage commented 3 years ago

Now I will merge them and register v0.10.11. These two commits should not affect the superficial behavior, so if PkgEval does not show any problems, I think we can move on.

Edit: Also, we may need to check if it works with Julia v1.5.4 and v1.6.0-rc2.

kimikage commented 3 years ago

Hmmm, there is still a problem with #233 :confused: