search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
77 stars 35 forks source link

Add component iterator #260

Closed kimikage closed 2 years ago

kimikage commented 2 years ago

This adds a component iterator as a "private" API. This re-implements the folding functions with the iterator.

cf. #190, #247

codecov[bot] commented 2 years ago

Codecov Report

Merging #260 (a6f4d8d) into master (87364c4) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   83.76%   83.80%   +0.04%     
==========================================
  Files           8        8              
  Lines         733      735       +2     
==========================================
+ Hits          614      616       +2     
  Misses        119      119
Impacted Files Coverage Δ
src/conversions.jl 85.71% <100.00%> (+0.17%) :arrow_up:
src/operations.jl 98.44% <100.00%> (+0.06%) :arrow_up:
src/show.jl 94.64% <100.00%> (-0.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87364c4...a6f4d8d. Read the comment docs.

kimikage commented 2 years ago

There is still a lot of room for discussion and improvement, but the iteration feature is useful for addressing the rest of the issues, so I will merge this first.