search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
77 stars 35 forks source link

[WIP] Optimize `hue` and implement `polar_to_cartesian` #262

Closed kimikage closed 3 months ago

kimikage commented 2 years ago

This is a port of the improvements made in Colors.jl. cf. https://github.com/JuliaGraphics/Colors.jl/pull/495 and https://github.com/JuliaGraphics/Colors.jl/pull/510

I am slightly uncomfortable with the presence of specialized methods such as atan360 and sincos360 in ColorTypes.jl. However, the problem with Julia itself will not be fully resolved until the next LTS support ends, and I don't want to add new package dependencies.

This should be merged just before the release of ColorTypes v0.12.

codecov[bot] commented 2 years ago

Codecov Report

Merging #262 (879de55) into master (87364c4) will increase coverage by 0.36%. The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   83.76%   84.12%   +0.36%     
==========================================
  Files           8        8              
  Lines         733      775      +42     
==========================================
+ Hits          614      652      +38     
- Misses        119      123       +4
Impacted Files Coverage Δ
src/precompile.jl 0.00% <0.00%> (ø)
src/traits.jl 99.09% <100.00%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87364c4...879de55. Read the comment docs.