search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
78 stars 36 forks source link

disable precompilation due to package load time increase #270

Closed KristofferC closed 2 years ago

KristofferC commented 2 years ago

Fixes https://github.com/JuliaGraphics/ColorTypes.jl/issues/269

I am not sure this was the conclusion of the discussion in there but I am putting up this in case it is ok.

codecov[bot] commented 2 years ago

Codecov Report

Merging #270 (b1a55a0) into master (6cbe7ab) will increase coverage by 0.25%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   82.90%   83.16%   +0.25%     
==========================================
  Files           8        8              
  Lines         772      772              
==========================================
+ Hits          640      642       +2     
+ Misses        132      130       -2
Impacted Files Coverage Δ
src/ColorTypes.jl 100.00% <ø> (ø)
src/operations.jl 100.00% <0.00%> (+1.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6cbe7ab...b1a55a0. Read the comment docs.

timholy commented 2 years ago

I think it is the conclusion, but unless it's urgent I'm planning to hold off a bit on merging this to see if I can finish the changes to precompilation that make make this pain-free. I plan on merging it either way, but is it OK to wait a week or so and see what transpires?

KristofferC commented 2 years ago

No urgency on my part.

johnnychen94 commented 2 years ago

I've cherry-picked this commit and released v0.11.4.