search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
78 stars 36 forks source link

ColorTypes v0.12.0-dev #281

Closed johnnychen94 closed 2 years ago

johnnychen94 commented 2 years ago

To avoid unexpected version bump such as #273

codecov[bot] commented 2 years ago

Codecov Report

Merging #281 (28fcdb9) into master (b8ed378) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files           8        8           
  Lines         777      777           
=======================================
  Hits          653      653           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8ed378...28fcdb9. Read the comment docs.

kimikage commented 5 months ago

@johnnychen94 I believe that this is definitely better to have because an "accident" have actually happened.

However, there is some ambiguity regarding the intent of this. That is, I don't know if these “-dev” declarations are restrictions on the package itself, or restrictions that also apply to downstream packages. To change the perspective, the question is whether ColorTypes v0.12.0 should include FixedPointNumbers v0.9.0-dev (or simply v0.9) in the [compat], or not.

As of three years ago, ColorTypes v0.12 was scheduled to drop support for FixedPointNumbers v0.8 and earlier. While some planning changes are necessary, I believe that is still a reasonable choice as it stands. Dropping can be done at release time, but adding must be done during development.