search

JuliaGraphics / ColorTypes.jl

Basic color definitions and traits
Other
77 stars 35 forks source link

Add Oklab and Oklch #291

Closed eprovst closed 11 months ago

eprovst commented 11 months ago

Similar to pull request #271 using the terminology of CSS instead and including some tests.

As far as I can tell, I implemented everything needed. The gamutmin and gamutmax are from the CSS recommendation, but I'm not 100% certain it stays within the sRGB gamut, rather likely it does not.

eprovst commented 11 months ago

As far as I can tell, this is complete yes. gamutmin and gamutmax might need tweaking, but the current values should at least be reasonable upper bounds. :)

timholy commented 11 months ago

That's as good as some of the other colorspaces, so I'm fine with that.

timholy commented 11 months ago

Thanks!

Getting this out in a release is a little complicated: we already have some breaking stuff merged and there's still #251. Are you in a hurry to get this out or is a bit of a delay OK?

eprovst commented 11 months ago

It would be useful for some long term project, but there's no rush. Of course, the complementary pull request in Colors.jl depends on a release here.