Closed kimikage closed 2 years ago
Merging #509 (2466f17) into master (2b553ad) will decrease coverage by
0.05%
. The diff coverage is94.33%
.
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 94.07% 94.01% -0.06%
==========================================
Files 9 9
Lines 1249 1270 +21
==========================================
+ Hits 1175 1194 +19
- Misses 74 76 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/precompile.jl | 0.00% <0.00%> (ø) |
|
src/utilities.jl | 95.23% <50.00%> (-0.37%) |
:arrow_down: |
src/colormaps.jl | 96.85% <94.93%> (+2.06%) |
:arrow_up: |
src/algorithms.jl | 75.00% <100.00%> (-0.48%) |
:arrow_down: |
src/conversions.jl | 99.42% <100.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2b553ad...2466f17. Read the comment docs.
Remaining problems:
RGB
-->LCH
conversion~ (PR #511 can fix this) Edit: Mergedvcat
in _diverging_palette
~ Edit: FixedThese can be tackled in separate PRs, though.
This uses
Tuple
instead ofVector
for thecolormap
parameters. (cf. https://github.com/JuliaGraphics/Colors.jl/commit/ddfe8d5f3aa69bdc566d28c82b81446575735a86) This also unifies the type of preset values toFloat64
.However, at present, there is no speed improvement. :sob: I will make some more tweaks and add some tests. This is more of a compilation time issue than a runtime performance issue. I am guessing that there is some relation between the precompilation problem with
colormap
and #496.before
after (w/o PR #511)
after (w/ PR #511)
This also fixes the problem with hue interpolation.![colormap_hue](https://user-images.githubusercontent.com/12679384/131423065-93d8405d-463d-4499-b31c-ada5221ffaad.png)