JuliaGraphics / Colors.jl

Color manipulation utilities for Julia
Other
200 stars 44 forks source link

Switch to SnoopPrecompile #529

Open timholy opened 1 year ago

timholy commented 1 year ago

On my machine, the workload inside the @precompile_all_calls goes from 0.3s with the previous precompile script to 0.08s with the new one, a 4x reduction. Given that we don't have precompiles anymore in ColorTypes (see https://github.com/JuliaGraphics/ColorTypes.jl/issues/270, a decision I agree with), this package seems like a good place to have some.

Measurements conducted on something like nightly but it should be applicable to the upcoming Julia 1.9.

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.82% // Head: 98.82% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (ac20a14) compared to base (b0d1b59). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #529 +/- ## ======================================= Coverage 98.82% 98.82% ======================================= Files 10 10 Lines 1274 1275 +1 ======================================= + Hits 1259 1260 +1 Misses 15 15 ``` | [Impacted Files](https://codecov.io/gh/JuliaGraphics/Colors.jl/pull/529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics) | Coverage Δ | | |---|---|---| | [src/Colors.jl](https://codecov.io/gh/JuliaGraphics/Colors.jl/pull/529/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics#diff-c3JjL0NvbG9ycy5qbA==) | `100.00% <ø> (ø)` | | | [src/precompile.jl](https://codecov.io/gh/JuliaGraphics/Colors.jl/pull/529/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timholy commented 1 year ago

On nightly, I can't detect any difference in load time between master and this branch: master is 0.189s, this branch is 0.186s.

kimikage commented 2 months ago

This will likely be merged, but in any case it's PrecompileTools now.