Closed bjarthur closed 7 years ago
No that's perfect! I also wanted to remove them in GLVisualize but didn't get to it...
tests are passing on 0.5
hmmm.... i didn't patch __init__
from GLVisualize. should we port that too so users don't have to manually call init
and done
?
Yes! :)
On 10 Mar 2017 22:55, "Ben Arthur" notifications@github.com wrote:
hmmm.... i didn't patch init from GLVisualize. should we port that too so users don't have to manually call init and done?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaGraphics/FreeTypeAbstraction.jl/pull/3#issuecomment-285795299, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9rI3GE_R6V3lywkcb49QrywIJqxt2Cks5rkcbFgaJpZM4MZiv9 .
So just add the __init__
and I can merge ;)
__init__
added, but let me use this in practice a bit before you merge
this is ready to merge i think unless anyone has comments
Can we deactivate tests on 0.6, or switch to StaticArrays? The switch should very straightforward ;)
added another commit to switch to StaticArrays. tests have already passed on linux; waiting to start on os x, where they work locally
Great! :)
all tests have passed
i didn't include
force_ucs2_charmap
orFontFace
because they appeared not to be used in FreeTypeAbstraction or GLVisualize. let me know if you'd prefer to retain them.