JuliaGraphics / FreeTypeAbstraction.jl

A Julian abstraction layer over FreeType.jl
Other
25 stars 21 forks source link

apply patches from GLVisualize #3

Closed bjarthur closed 7 years ago

bjarthur commented 7 years ago

i didn't include force_ucs2_charmap or FontFace because they appeared not to be used in FreeTypeAbstraction or GLVisualize. let me know if you'd prefer to retain them.

SimonDanisch commented 7 years ago

No that's perfect! I also wanted to remove them in GLVisualize but didn't get to it...

bjarthur commented 7 years ago

tests are passing on 0.5

bjarthur commented 7 years ago

hmmm.... i didn't patch __init__ from GLVisualize. should we port that too so users don't have to manually call init and done?

SimonDanisch commented 7 years ago

Yes! :)

On 10 Mar 2017 22:55, "Ben Arthur" notifications@github.com wrote:

hmmm.... i didn't patch init from GLVisualize. should we port that too so users don't have to manually call init and done?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaGraphics/FreeTypeAbstraction.jl/pull/3#issuecomment-285795299, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9rI3GE_R6V3lywkcb49QrywIJqxt2Cks5rkcbFgaJpZM4MZiv9 .

SimonDanisch commented 7 years ago

So just add the __init__ and I can merge ;)

bjarthur commented 7 years ago

__init__ added, but let me use this in practice a bit before you merge

bjarthur commented 7 years ago

this is ready to merge i think unless anyone has comments

SimonDanisch commented 7 years ago

Can we deactivate tests on 0.6, or switch to StaticArrays? The switch should very straightforward ;)

bjarthur commented 7 years ago

added another commit to switch to StaticArrays. tests have already passed on linux; waiting to start on os x, where they work locally

SimonDanisch commented 7 years ago

Great! :)

bjarthur commented 7 years ago

all tests have passed