lhupe commented 3 years ago

This PR adds the standard path fo user fonts in modern Linux desktop systems, as well as fixing the existing ~/.fonts path.

codecov[bot] commented 3 years ago

Codecov Report

Merging #49 into master will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   73.51%   73.62%   +0.10%     
==========================================
  Files           5        5              
  Lines         253      254       +1     
==========================================
+ Hits          186      187       +1     
  Misses         67       67

Impacted Files	Coverage Δ
src/findfonts.jl	`87.50% <100.00%> (+0.22%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 483bc92...ab5830a. Read the comment docs.

SimonDanisch commented 3 years ago

Did you make sure somehow, that this works ?

lhupe commented 3 years ago

Yes, I did (on two different Linux systems). However, originally, I only checked for a font installed in a subdirectory of ~/.local/share/fonts/. I just repeated my test with a font installed directly to /.fonts and noticed that while all subdirectories of the specified directories are added to the font path list, the directory itself is ignored. My latest commit should fix this.

lhupe commented 3 years ago

is there anything that still needs to be done before this is merged?

SimonDanisch commented 3 years ago

Oh, I guess I was just waiting for the CI to go green after your changes :D

JuliaGraphics / FreeTypeAbstraction.jl

Improve Linux font paths #49

Codecov Report