search

JuliaGraphics / FreeTypeAbstraction.jl

A Julian abstraction layer over FreeType.jl
Other
25 stars 20 forks source link

`face.glyph` should be used as a pointer instead of a value #57

Closed Gnimuc closed 3 years ago

Gnimuc commented 3 years ago

Not sure the reason why it was used in this way. I guess the binding for this type generated by old Clang.jl is wrong. Now, this should be fixed by https://github.com/JuliaGraphics/FreeType.jl/pull/41 with Clang.jl's new generator.

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (4929688) into master (5bf8cfe) will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   75.00%   74.90%   -0.10%     
==========================================
  Files           6        6              
  Lines         276      275       -1     
==========================================
- Hits          207      206       -1     
  Misses         69       69
Impacted Files Coverage Δ
src/rendering.jl 94.02% <100.00%> (ø)
src/types.jl 65.59% <100.00%> (-0.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bf8cfe...4929688. Read the comment docs.

SimonDanisch commented 3 years ago

Oh cool! Yeah I had a lot of trouble & agony with this section!

Gnimuc commented 3 years ago

The latest commit fixed the compat and bumped the version of this package.