Closed ffreyer closed 2 years ago
Merging #64 (bf43e8c) into master (4db586e) will increase coverage by
0.33%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 75.25% 75.58% +0.33%
==========================================
Files 6 6
Lines 299 299
==========================================
+ Hits 225 226 +1
+ Misses 74 73 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/rendering.jl | 93.15% <100.00%> (ø) |
|
src/types.jl | 67.96% <0.00%> (+0.97%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4db586e...bf43e8c. Read the comment docs.
Interesting, that this creates some artifacts:
I've noticed that too, but I don't think that's because of this change. If you look at x or v you can see artifacts in both, but they move a little between the two versions.
Saving just v
from a 64px render with FileIO:
with Makie heatmap:
Interesting...
Oh right - that's because heatmaps are shifted by 0.5. Translating the plot to integer values removes these artifacts.
Running
currently generates
because the horizontal bearings are applied in the wrong direction. With these changes I get