search

JuliaGraphics / FreeTypeAbstraction.jl

A Julian abstraction layer over FreeType.jl
Other
25 stars 20 forks source link

clip render if outside supplied matrix #7

Closed bjarthur closed 7 years ago

bjarthur commented 7 years ago

before it threw an error, now it simply crops text to the edges of the matrix. so if the y,x coordinates and align args are such that the render spills across a border, then that portion outside the bounds will simply not be rendered, but that inside will be.

bjarthur commented 7 years ago

tests pass on julia 0.5.1. ready to merge i think.

bjarthur commented 7 years ago

any thoughts on this?

SimonDanisch commented 7 years ago

This fails on 0.6. Do you want to try to test this with the changes in #8 and see if it passes?

bjarthur commented 7 years ago

two options: 1. merge this now so this functionality exists for 0.5; 2. merge #8 first, and then i'll rebase this afterwards. downside of the latter is that this functionality would then only be available for 0.6. option 1 is more work for you, option 2 is more work for me. i'm fine either way.

SimonDanisch commented 7 years ago

I'm trying to make #8 work with 0.5 right now

bjarthur commented 7 years ago

i've rebased with master, and all tests pass. can you please merge? i don't have write access. thx.

SimonDanisch commented 7 years ago

Great thanks!