t-bltg commented 2 years ago

@SimonDanisch, I also need setting the per char background color for drawing UnicodePlots colorbars gradients:

pr foo_ok

master foo

In order not to break the current, I've named it gcolor as opposed to bcolor for the whole ~~image~~ row background color.

I hope this won't break Makie, but I'm not certain of it atm, how can I test this ?

codecov[bot] commented 2 years ago

Codecov Report

Merging #70 (465e5f9) into master (9c6b7e2) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   75.74%   75.90%   +0.16%     
==========================================
  Files           6        6              
  Lines         301      303       +2     
==========================================
+ Hits          228      230       +2     
  Misses         73       73

Impacted Files	Coverage Δ
src/rendering.jl	`93.50% <100.00%> (+0.17%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4043923...465e5f9. Read the comment docs.

SimonDanisch commented 2 years ago

Run the Makie tests, I guess? But renderstring! shouldn't be used in Makie🤷

t-bltg commented 2 years ago

Oh, ok I could swear I've seen it somewhere lying in Makie. Nervermind then ;)

SimonDanisch commented 2 years ago

This isn't breaking because of gcolor right?

t-bltg commented 2 years ago

Normally no, but the unit tests are not extensively testing it.

JuliaGraphics / FreeTypeAbstraction.jl

Support per char background color #70

Codecov Report