Closed t-bltg closed 2 years ago
Merging #71 (4e381e7) into master (cdcddd0) will increase coverage by
15.35%
. The diff coverage is96.03%
.
@@ Coverage Diff @@
## master #71 +/- ##
===========================================
+ Coverage 75.90% 91.26% +15.35%
===========================================
Files 6 6
Lines 303 332 +29
===========================================
+ Hits 230 303 +73
+ Misses 73 29 -44
Impacted Files | Coverage Δ | |
---|---|---|
src/types.jl | 83.83% <80.00%> (+15.87%) |
:arrow_up: |
src/findfonts.jl | 93.65% <88.88%> (+3.02%) |
:arrow_up: |
src/layout.jl | 97.67% <100.00%> (+45.40%) |
:arrow_up: |
src/rendering.jl | 97.32% <100.00%> (+3.81%) |
:arrow_up: |
src/FreeTypeAbstraction.jl | 100.00% <0.00%> (+30.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 53b4655...4e381e7. Read the comment docs.
@SimonDanisch, if you have 5min to review, it'd be appreciated ...
So, I'm failing to understand all the subtleties of the previous bearing computations and why this was chosen, but the examples given in https://github.com/JuliaGraphics/FreeTypeAbstraction.jl/pull/71#issue-1181220071 now work without changing the bearing
definition :shrug:, and I'm fine with that.
Code style have been (hopefully) reverted, minus fixing the code style inconsistencies.
Alright thanks a lot, this works with Makie! :)
Thank you very much for your time, saving correct png
s is a nice improvement for UnicodePlots
;)
renderstring!
(debug), not perfect yet (some unit offsets can be observed on specific glyphs), but quite ok on averagefix incorrectbearing
computation: https://github.com/JuliaGraphics/FreeTypeAbstraction.jl/blob/53b4655d51e2bd62f651ede9368abe561fa81db2/src/types.jl#L106gstr
to fill background for distinct characters (needed forUnicodePlots
, for e.g. a row of blocks █)incx
to offsetx advance
(needed forUnicodePlots
inheatmap, histogram
)76% -> 91%
Needed for https://github.com/JuliaPlots/UnicodePlots.jl/pull/242.
Visual inspection of bounding boxes on individual characters is tested with the following code:
Updated
UnicodePlots
plots with this PR are show here: https://github.com/JuliaPlots/UnicodePlots.jl/pull/243/files.Here is an example using bounding boxes and braille or block characters + background filling (height correctly adjusted per row):