codecov[bot]
commented
2 years ago Codecov Report
Merging #72 (2167535) into master (0fa364e) will increase coverage by
3.35%. The diff coverage is97.22%.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 91.26% 94.62% +3.35%
==========================================
Files 6 6
Lines 332 316 -16
==========================================
- Hits 303 299 -4
+ Misses 29 17 -12 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/types.jl | 94.23% <93.75%> (+10.39%) |
:arrow_up: |
| src/layout.jl | 100.00% <100.00%> (+2.32%) |
:arrow_up: |
| src/rendering.jl | 98.23% <100.00%> (+0.90%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d0598f6...2167535. Read the comment docs.
This PR changes the base glyph representation to a UInt64 index, which can directly pick a glyph out of a font without the unicode char detour. This allows the methods to work for special scenarios like in MathTeXEngine.jl
The old way of accessing things via Char should still work, they are just converted to UInt64 indices along the way. The same for
Stringwhich can access a glyph by name if there's one (likeintegral.v1).Because of the string name based glyph finding, and because that functionality is not used anymore in Makie (and elsewhere?) I've removed methods for simple string layouts / boundingboxes.