search

JuliaGraphics / FreeTypeAbstraction.jl

A Julian abstraction layer over FreeType.jl
Other
25 stars 20 forks source link

Use BaseDirs for locating font directories #82

Open tecosaur opened 8 months ago

tecosaur commented 8 months ago

Identifying the correct platform-specific font directories can be done mostly correctly most of the time just with a hardcoded list of places to look (particularly on Apple systems). However, on Windows and XDG-following (i.e. Linux and friends) systems the user and system font directories can end up in other places, and accommodating these edge cases takes some effort.

This effort has already been put in with the BaseDirs package, which is a small zero-dependency package whose entire purpose is to find the correct directories for different types of content on various platforms. So, we can remove the current font-folder-finding code entirely and just call BaseDirs.fonts() for a reduction in code here and an improvement in compatibility.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (077003e) 95.26% compared to head (166378c) 96.07%.

Files Patch % Lines
src/FreeTypeAbstraction.jl 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #82 +/- ## ========================================== + Coverage 95.26% 96.07% +0.81% ========================================== Files 6 6 Lines 317 306 -11 ========================================== - Hits 302 294 -8 + Misses 15 12 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tecosaur commented 8 months ago

It seems like codecov is complaining about the line @static if Sys.isunix() && !Sys.isapple() not being tested (I don't think it can be hit at runtime while @static applies).