Closed oheil closed 2 years ago
Merging #236 (e2f2334) into master (9025ca4) will decrease coverage by
0.00%
. The diff coverage is90.00%
.
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 32 32
Lines 6186 6185 -1
==========================================
- Hits 4552 4551 -1
Misses 1634 1634
Impacted Files | Coverage Δ | |
---|---|---|
src/drawings.jl | 63.47% <90.00%> (-0.16%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9025ca4...e2f2334. Read the comment docs.
Looks fine and doesn't break anything... I'm trying to think when I'd want multiple simultaneously-open drawings, but perhaps you'll write some persuasive use cases some day!
My guess is, I will fail with the persuasiveness ;-)
I for one am already persuaded, as I have missed the opportunity to annotate a figure, and then proceed to evolve the graphics in scripting style. The answer so far for me has been to put all drawing operations inside a function, which adds work in itself.
Please test thoroughly!
Only if you want it. It doesn't break any code, it's only an internal change not documented. If you decide to pull it, I will do some more effort to make it exposable for Luxor users and write the documents and examples for it. All tests pass. Or just close it without pulling.