JuliaGraphics / Luxor.jl

Simple drawings using vector graphics; Cairo "for tourists!"
http://juliagraphics.github.io/Luxor.jl/
Other
576 stars 72 forks source link

allow multipe drawings #236

Closed oheil closed 2 years ago

oheil commented 2 years ago

Only if you want it. It doesn't break any code, it's only an internal change not documented. If you decide to pull it, I will do some more effort to make it exposable for Luxor users and write the documents and examples for it. All tests pass. Or just close it without pulling.

codecov[bot] commented 2 years ago

Codecov Report

Merging #236 (e2f2334) into master (9025ca4) will decrease coverage by 0.00%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   73.58%   73.58%   -0.01%     
==========================================
  Files          32       32              
  Lines        6186     6185       -1     
==========================================
- Hits         4552     4551       -1     
  Misses       1634     1634              
Impacted Files Coverage Δ
src/drawings.jl 63.47% <90.00%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9025ca4...e2f2334. Read the comment docs.

cormullion commented 2 years ago

Looks fine and doesn't break anything... I'm trying to think when I'd want multiple simultaneously-open drawings, but perhaps you'll write some persuasive use cases some day!

oheil commented 2 years ago

My guess is, I will fail with the persuasiveness ;-)

hustf commented 2 years ago

I for one am already persuaded, as I have missed the opportunity to annotate a figure, and then proceed to evolve the graphics in scripting style. The answer so far for me has been to put all drawing operations inside a function, which adds work in itself.

Please test thoroughly!