multi drawings complete (somehow)

[codecov[bot]]

Codecov Report

Merging #237 (72e532f) into master (600ab38) will increase coverage by 0.07%. The diff coverage is 90.74%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   73.58%   73.65%   +0.07%     
==========================================
  Files          32       32              
  Lines        6185     6203      +18     
==========================================
+ Hits         4551     4569      +18     
  Misses       1634     1634              

Impacted Files	Coverage Δ
src/drawings.jl	66.12% <90.74%> (+2.65%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 600ab38...72e532f. Read the comment docs.

[guo-yong-zhi]

Is this PR related to https://github.com/JuliaGraphics/Luxor.jl/issues/117?

[oheil]

No. Using threads and checking issues with it is next on my agenda... It is completing this https://github.com/JuliaGraphics/Luxor.jl/pull/236

[cormullion]

Perhaps some of these functions would be better named as ...index() and ...indices() since they return or set index values rather than drawing objects?

One day we might have named drawings (an extra field in the struct perhaps?) rather than these old-school numbers... 🙂

[oheil]

Actually they were named ...index ;-) and I found ...drawing better. But no problem, I will change back to index. And the named drawings I also thought already about, but thought, this is something for another time. One step per step :-)

[cormullion]

With multiple dispatch you could have drawing_index() for get and drawing_index(n) for set... Anyway, It can be done how you like.

[oheil]

Yes, of course, as you wish. There is not much like or dislike in me regarding those things. But perhaps you want it like the other geters and seters, e.g. get_current_redvalue() , set_current_redvalue(r), ...

[oheil]

1) get_indices() get_current_index() set_current_index(i::Int) get_next_index() set_next_index()

2) drawing_indices() drawing_index() drawing_index(i::Int) get_next_drawing_index() set_next_drawing_index()

or something else?

[cormullion]

Probably

drawing_indices()
get_drawing_index()
set_drawing_index()
get_next_drawing_index()
set_next_drawing_index()

are the most explicit, consistent, and predictable names. Longer but more self-explanatory...?

[oheil]

Yes, that's how it should be then 👍

[cormullion]

Thanks! Let's see how it works... :)