Closed gantz-giraffe closed 1 year ago
Base: 73.08% // Head: 73.02% // Decreases project coverage by -0.06%
:warning:
Coverage data is based on head (
3936f06
) compared to base (bf63b19
). Patch coverage: 87.50% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks! We'll either have to leave the old function name in as well, and deprecate it (since we cant just change function names whenever), or wait till the next major version (if my understanding of semver is correct). I'd suggest the former.
@gantz-giraffe Hi! Do you want this PR to make it into the next release - I'll probably release 3.6 soon, and this could go in with a few additions.
@cormullion yeah absolutely!
The underscores in the function name
rotate_point_around_point
don't conform with the naming conventions of most functions in the library, and the name is somewhat verbose. The more general namerotatepoint
also makes it so that there can be an intuitive secondary method which takes a single point and an angle as its arguments, and returns the point rotated around the canvas' origin.