JuliaGraphics / Luxor.jl

Simple drawings using vector graphics; Cairo "for tourists!"
http://juliagraphics.github.io/Luxor.jl/
Other
576 stars 72 forks source link

Remove precompile info to prevent precompile warning #264

Closed jaakkor2 closed 1 year ago

jaakkor2 commented 1 year ago

With Luxor v3.7.0 I see

(@v1.9) pkg> precompile
Precompiling project...
  165 dependencies successfully precompiled in 481 seconds. 304 already precompiled.
  1 dependency had warnings during precompilation:
┌ Luxor [ae8d54c2-7ccd-5906-9d76-62fc9837b5bc]
│  [ Info: SnoopPrecompile is analyzing Luxor.jl code...
└

Note: SnoopPrecompile has been miograted to PrecompileTools in https://github.com/JuliaGraphics/Luxor.jl/pull/263 , but there has not been a release.

I suggest removing the line

@info "PrecompileTools is analyzing Luxor.jl code..."

from https://github.com/JuliaGraphics/Luxor.jl/blob/master/src/precompile.jl

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (375bb99) 74.66% compared to head (53b2809) 74.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #264 +/- ## ======================================= Coverage 74.66% 74.67% ======================================= Files 33 33 Lines 6541 6542 +1 ======================================= + Hits 4884 4885 +1 Misses 1657 1657 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaGraphics/Luxor.jl/pull/264?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics) | Coverage Δ | | |---|---|---| | [src/precompile.jl](https://app.codecov.io/gh/JuliaGraphics/Luxor.jl/pull/264?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGraphics#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

cormullion commented 1 year ago

Thanks!