Closed hyrodium closed 2 months ago
How’s this going?
I'm sorry that I did not have time for OSS in recent days. I will try updating this PR tomorrow! 💪
I think the dictionary order with Point
should be also removed before releasing v4.
julia> Point(1,3) < Point(0,4)
false
julia> Point(1,3) < Point(2,1)
true
If you agree with that, I will fix this in another PR!
x-ref: https://github.com/JuliaGraphics/Luxor.jl/blob/master/test/point-arithmetic.jl#L46-L48
Sure! Just let me know when you’ve finished all the changes you feel are important - then I can go ahead and make the 4.0 release.
This is ready for review!
Sorry for the late PR. This PR is related to this comment: https://github.com/JuliaGraphics/Luxor.jl/pull/295#issuecomment-1983474107.
Changes in this PR:
Point(1,2) .+ 3
is now invalid.Point(1,2) + Point(3,3)
instead.CHANGELOG.md
is also updated.[Point(1,2), Point(4,1)] .+ Point(3,4)
is now valid.Ref
in code.Ref
inbetween.(Ref(pt1), Ref(pt2), range)
.between
methods introduced in https://github.com/JuliaGraphics/Luxor.jl/commit/90d006b539c611008d4a6112e9d7e3b752186788.v3.8.0
,[Point(1,2), Point(4,1)] .+ Point(3,4)
was valid too.[Point(1,2), Point(4,1)] .+ Point(3,4)
turned invalid, and we needed to write[Point(1,2), Point(4,1)] .+ Ref(Point(3,4))
instead.[Point(1,2), Point(4,1)] + Point(3,4)
is now valid.[Point(1,2), Point(4,1)] .+ Ref(Point(3,4))
is also still valid.