JuliaGraphics / Luxor.jl

Simple drawings using vector graphics; Cairo "for tourists!"
http://juliagraphics.github.io/Luxor.jl/
Other
575 stars 72 forks source link

Update around broadcasting #300

Closed hyrodium closed 2 months ago

hyrodium commented 3 months ago

Sorry for the late PR. This PR is related to this comment: https://github.com/JuliaGraphics/Luxor.jl/pull/295#issuecomment-1983474107.

Changes in this PR:

cormullion commented 3 months ago

How’s this going?

hyrodium commented 3 months ago

I'm sorry that I did not have time for OSS in recent days. I will try updating this PR tomorrow! 💪

hyrodium commented 3 months ago

I think the dictionary order with Point should be also removed before releasing v4.

julia> Point(1,3) < Point(0,4)
false

julia> Point(1,3) < Point(2,1)
true

If you agree with that, I will fix this in another PR!

x-ref: https://github.com/JuliaGraphics/Luxor.jl/blob/master/test/point-arithmetic.jl#L46-L48

cormullion commented 3 months ago

Sure! Just let me know when you’ve finished all the changes you feel are important - then I can go ahead and make the 4.0 release.

hyrodium commented 2 months ago

This is ready for review!