search

JuliaGraphics / Winston.jl

2D plotting for Julia
MIT License
171 stars 55 forks source link

Fix gtk backend and make it default #288

Closed tknopp closed 6 years ago

tknopp commented 6 years ago

@ararslan:

In order to make it default I actually had to track down an issue which actually means that the gtk backend was never working on Julia 0.6.

If I get your approval I would do then the next step and remove the tk code. The current switch between Gtk and Winston is really not compatible with precompilation.

ararslan commented 6 years ago

Thanks! I think this is the right way to go, but I'd like to hear from @nolta before removing Tk entirely.

nolta commented 6 years ago

If Gtk works, I'm fine w/ removing Tk.

tknopp commented 6 years ago

@ararslan: ping (I do not have write access)

ararslan commented 6 years ago

Going to close and reopen to run CI on 0.6.

ararslan commented 6 years ago

Should we document somewhere that Gtk is now the default rather than Tk?

ararslan commented 6 years ago

Looks like we'll need to swap Tk in REQUIRES for Gtk.

tknopp commented 6 years ago

It does not seem to be documented that Tk is used. And indeed the REQUIRES needs to be switched.

tknopp commented 6 years ago

@ararslan: I have changes the REQUIRE and travis seems to be fine with that now. Could you merge?