search

JuliaGraphics / Winston.jl

2D plotting for Julia
MIT License
171 stars 55 forks source link

Not working in Julia 1.0 #293

Closed ma-laforge closed 5 years ago

ma-laforge commented 5 years ago

I tried Winston again given that @tknopp informed us that is was ready for Julia 1.0: https://discourse.julialang.org/t/plotting-packages-that-support-julia-v1-0/14125/33

I tried running the following simple example with Winston from Julia 1.0, with no success:

using Winston
x=collect(-10:10)
plot(x, x.^3)
> Error showing value of type FramedPlot:
> ERROR: UndefVarError: showall not defined

NOTE: I get the same issue if I move to the most recent version of Winston on the master branch.

I admit, it does work from Julia 0.7, though. However, I have found that even after porting to Julia 0.7, there will still be a few small issues that need fixed by debugging your package in Julia 1.0 directly (the missing showall function in 1.0, for example).

test directory

I also tried running some of the code from the test directory (runtests.jl). Overall, this runs relatively well in 0.7 (though there appears to be a few snags). Sadly, I cannot get the test code to run at all on Julia 1.0.

Again, I think this is one of those cases where the code must be updated/debugged using Julia 1.0 itself. The execution seems to get caught on silly little things like @sprintf having been moved (@sprintf must now be imported from the Printf module (import Printf: @sprintf))

tknopp commented 5 years ago

Uh, sorry, then I spoke to fast (and thanks for testing!). I am currently using 0.7 and thought that I got positive travis results from 1.0 but apparently not. Will have a look.

tknopp commented 5 years ago

ok, the showall was simple. For me the test pass on 1.0

tknopp commented 5 years ago

@ma-laforge: could you be more specific what you tested regarding the @sprintf issue? In runtests.jl we have using Printf. Or did you execute individual test files (instead of runtests.jl)?

tknopp commented 5 years ago

tests are passing: https://travis-ci.org/JuliaGraphics/Winston.jl/builds/430611531 Despite the tests not running on Linux / 0.7

tknopp commented 5 years ago

@ma-laforge please reopen, if I missed something

ma-laforge commented 5 years ago

Sorry. I had an issue with @sprintf when I ran test/plot.jl. I was desperate to try to get a plot working. I did not know that only runtests.jl ran by itself.

tknopp commented 5 years ago

don't worry. Now everything is working and that is what counts. Thanks a lot for the bug report!