search

JuliaGraphics / Winston.jl

2D plotting for Julia
MIT License
171 stars 55 forks source link

Update plot.jl #300

Closed ezaron closed 2 years ago

ezaron commented 5 years ago

use shades of gray to indicate NaN and Inf in imagesc plots.

ezaron commented 5 years ago

This pull request is very simple. It adds two shades of gray to imagesc to differentiate NaN and Inf values of the plotted array. Would you please consider adding it to your Winston.jl so it is pulled in by the Julia package manager?

codecov[bot] commented 2 years ago

Codecov Report

Merging #300 (c450190) into master (e9e1d3c) will increase coverage by 0.28%. The diff coverage is 33.33%.

:exclamation: Current head c450190 differs from pull request most recent head 659db92. Consider uploading reports for the commit 659db92 to get more accurate results

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   55.27%   55.55%   +0.28%     
==========================================
  Files          10       10              
  Lines        2560     2700     +140     
==========================================
+ Hits         1415     1500      +85     
- Misses       1145     1200      +55
Impacted Files Coverage Δ
src/plot.jl 50.98% <33.33%> (-1.23%) :arrow_down:
src/contour.jl 0.00% <0.00%> (ø)
src/canvas3d.jl 0.00% <0.00%> (ø)
src/plot_interfaces.jl 0.00% <0.00%> (ø)
src/Winston.jl 63.26% <0.00%> (+0.32%) :arrow_up:
src/geom.jl 56.25% <0.00%> (+0.69%) :arrow_up:
src/paint.jl 60.58% <0.00%> (+0.71%) :arrow_up:
src/config.jl 95.83% <0.00%> (+2.35%) :arrow_up:
src/renderer.jl 71.85% <0.00%> (+2.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9e1d3c...659db92. Read the comment docs.

tknopp commented 2 years ago

why did you remove the workflows?