search

JuliaGraphs / GraphIO.jl

Graph IO functionality for various formats.
Other
61 stars 28 forks source link

remove Requires #42

Closed GiggleLiu closed 11 months ago

GiggleLiu commented 3 years ago

Remove conditional dependencies.

# GraphIO alone
julia> @time using GraphIO
  1.376940 seconds (3.12 M allocations: 221.025 MiB, 2.51% gc time, 32.49% compilation time)
# Remove Requires and restart
julia> @time using GraphIO
  1.775102 seconds (3.73 M allocations: 253.879 MiB, 2.98% gc time, 44.93% compilation time)
filchristou commented 2 years ago

is there any reason why this is not merged ? Is there any other plans for the future design of this package ?

simonschoelly commented 2 years ago

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

GiggleLiu commented 2 years ago

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

I fix it because there are a lot bugs, I just can not load graph6 module. And keno find the similar bug. Well, I forgot to mention those bugs in the pr.

gdalle commented 1 year ago

This should probably be done with extensions now

filchristou commented 11 months ago

yes, can we close this ?